Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data plane view support #209

Merged
merged 30 commits into from
Aug 23, 2024
Merged

feat: data plane view support #209

merged 30 commits into from
Aug 23, 2024

Conversation

wenytang-ms
Copy link
Contributor

@wenytang-ms wenytang-ms commented Jul 22, 2024

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 51.22200% with 479 lines in your changes missing coverage. Please review.

Project coverage is 43.85%. Comparing base (b120891) to head (b715df5).
Report is 1 commits behind head on dev.

Files Patch % Lines
src/azure/azureLogin/dataSessionProvider.ts 36.50% 80 Missing ⚠️
src/tree/DataPlaneAccount.ts 36.52% 73 Missing ⚠️
src/extension.ts 0.00% 52 Missing ⚠️
src/azure/ApiCenter/ApiCenterDataPlaneAPIs.ts 39.65% 35 Missing ⚠️
src/azure/ApiCenterDefines/ApiCenterDefinition.ts 72.95% 33 Missing ⚠️
src/azure/ApiCenterDefines/ApiCenterApi.ts 77.68% 27 Missing ⚠️
src/azure/ApiCenterDefines/ApiCenterVersion.ts 73.26% 27 Missing ⚠️
src/utils/treeUtils.ts 27.02% 27 Missing ⚠️
src/commands/addDataPlaneApis.ts 23.52% 26 Missing ⚠️
src/commands/removeDataplaneApi.ts 0.00% 18 Missing ⚠️
... and 16 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #209      +/-   ##
==========================================
+ Coverage   42.09%   43.85%   +1.75%     
==========================================
  Files          83       92       +9     
  Lines        4955     5774     +819     
  Branches      126      146      +20     
==========================================
+ Hits         2086     2532     +446     
- Misses       2868     3241     +373     
  Partials        1        1              
Files Coverage Δ
src/azure/ApiCenter/ApiCenterRestAPIs.ts 100.00% <100.00%> (ø)
src/azure/ApiCenter/contracts.ts 100.00% <100.00%> (ø)
src/azure/ResourceGraph/ResourceGraphService.ts 47.22% <100.00%> (ø)
src/azure/azureLogin/authTypes.ts 100.00% <100.00%> (ø)
src/commands/handleUri.ts 100.00% <100.00%> (ø)
src/constants.ts 100.00% <100.00%> (ø)
src/extensionVariables.ts 100.00% <100.00%> (ø)
src/tree/SubscriptionTreeItem.ts 45.58% <100.00%> (ø)
src/uiStrings.ts 100.00% <100.00%> (ø)
src/tree/ApiCenterTreeItem.ts 60.00% <66.66%> (ø)
... and 25 more

@wenytang-ms wenytang-ms marked this pull request as ready for review August 2, 2024 08:36
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@sthirthala sthirthala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the package.nls and uistrings

This PR has other things which I have not reviewed.

package.json Outdated Show resolved Hide resolved
src/uiStrings.ts Outdated Show resolved Hide resolved
src/constants.ts Outdated Show resolved Hide resolved
Copy link
Member

@formulahendry formulahendry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good now. Just some small comments.

src/uiStrings.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@sthirthala sthirthala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment - we should likely change Remove API Center to be Disconnect from API Center

package.nls.json Outdated Show resolved Hide resolved
@wenytang-ms wenytang-ms merged commit 9ff2c47 into dev Aug 23, 2024
10 checks passed
@wenytang-ms wenytang-ms deleted the wenyt/auth1 branch August 23, 2024 01:55
wenytang-ms added a commit that referenced this pull request Sep 19, 2024
* test: create general purpose vscode operator function & finish select azure tenant test case (#225)

* feat: create general purpose vscode operator function & finish select azure tenant test case

* test: select tenant use env

* test: use dot env

* test: add codecov ignore test folder

* test: add codecov ignore test folder

* test: add codecov ignore test folder

* test: add codecov ignore test folder

* test: debug

* test: debug

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: yaml test

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: create general purpose vscode operator function & finish select azure tenant test case

* test: change case name

---------

Co-authored-by: Ivan_Chen <[email protected]>

* test: add auto case "Azure Tree View" (#232)

* add auto case "Azure Tree View"

* set single  test timeout

* select days sub first, then verify tree items

* use sub "AML Infra - Engineering System" to do the test

* remove local change

* Add verification for "Environments","Rules" and "Deployments"

* feat: data plane view support (#209)

* feat: rbac demo

* feat: support api server

* feat: update

* feat: ready

* feat: update

* feat: update

* test: update test case

* feat: add feautres

* docs: strings

* test: update

* feat: update command

* feat: change to b type

* feat: adjust treeitem view structure

* feat: update

* feat: update

* feat: separate defines

* feat: update

* feat: update

* test: add test cases

* test: add test cases

* fix: update the code according to comments

* fix: update code according to comments

* feat: update code

* feat: update

* feat: update

* fix: update

* test: fix comments and test cases

* test: update

* fix: update the uistring

* feat: add telemetry for dataplane (#238)

* feat: add telemetry for dataplane

* test: add test case

* test: add test case

* test: update

* test: update

* chore: add telemetry event for handleurl

* test: update

* fix: fix the comments

* fix: rename the telemetry event

* fix: update

* test: update

* test: update

* fix: update

* test: synchronize results to test plan (#239)

* build(deps): bump axios from 1.6.2 to 1.7.4 (#236)

Bumps [axios](https://github.com/axios/axios) from 1.6.2 to 1.7.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.6.2...v1.7.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: upgrade the upload artifact action version (#245)

* docs: add changelog and readme for data plane (#241)

* docs: add changelog and readme for data plane

* docs: update

* docs: update

* docs: update

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Siyuan Chen <[email protected]>
Co-authored-by: Ivan_Chen <[email protected]>
Co-authored-by: QinghuiMeng-M <[email protected]>
Co-authored-by: Helly Zhang <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants