Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET SDK Build Prompt For Project File Every Time #3993

Merged
merged 16 commits into from
Jul 11, 2023
Merged

.NET SDK Build Prompt For Project File Every Time #3993

merged 16 commits into from
Jul 11, 2023

Conversation

alexyaang
Copy link
Member

@alexyaang alexyaang commented Jul 3, 2023 •
edited
Loading

This PR addresses two things:

  1. It makes the .NET SDK Feature prompt user every time they f5 for a project file.
  2. It gets the image name from msbuild instead of assuming it from the project name

Mac

  • Single .csproj .NET application with SDK Build without scaffolding
  • Multi .csproj .NET application with SDK Build without scaffolding
  • Single .csproj .NET application with SDK Build with scaffolding
  • Single .csproj .NET application with Nomal Docker Build (check for regression)
  • Multi .csproj .NET application with SDK Build with scaffolding
  • Multi .csproj .NET application with SDK Build with old scaffolding in a new Workspace folder

Windows

  • Single .csproj .NET application with SDK Build without scaffolding
  • Multi .csproj .NET application with SDK Build without scaffolding

@alexyaang alexyaang requested a review from a team as a code owner July 3, 2023 17:27
bwateratmsft
bwateratmsft reviewed Jul 10, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
bwateratmsft
bwateratmsft reviewed Jul 10, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
@alexyaang alexyaang merged commit 20c4bad into main Jul 11, 2023
2 checks passed
@alexyaang alexyaang deleted the yangalex/netSdkImageName branch July 11, 2023 21:21
@microsoft microsoft locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danegsta danegsta danegsta left review comments

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexyaang @bwateratmsft @danegsta