Skip to content

Commit

Permalink
fix: runtime error when loading electron preloads (#1750)
Browse files Browse the repository at this point in the history
Didn't seem to actually cause any issues, just noticed and error in the logs.
  • Loading branch information
connor4312 authored Jul 7, 2023
1 parent 736fb4e commit 0244e87
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
## Nightly (only)

- fix: set breakpoints predictably when launching with files ([#1748](https://github.com/microsoft/vscode-js-debug/issues/1748))
- fix: don't overwrite custom NODE_OPTIONS ([#1746](https://github.com/microsoft/vscode-js-debug/issues/1746))

## v1.80 (June 2023)

Expand Down
5 changes: 5 additions & 0 deletions src/targets/sourcePathResolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ export abstract class SourcePathResolverBase<T extends ISourcePathResolverOption
return false;
}

// Empty URL modules present in Electron (found looking at #1741)
if (compiledPath === '') {
return false;
}

if (!this.resolvePatterns || this.resolvePatterns.length === 0) {
return true;
}
Expand Down

0 comments on commit 0244e87

Please sign in to comment.