fix: edge devtools incorrectly ask for local forwarding

Fixes microsoft/vscode#193110
microsoft · Sep 20, 2023 · b2abd3e · b2abd3e
1 parent 76ec0a3
commit b2abd3e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
 ## Nightly (only)
 
 - feat: show class names of methods in call stack view ([#1770](https://github.com/microsoft/vscode-js-debug/issues/1770))
+- fix: edge devtools incorrectly ask for local forwarding ([vscode#193110](https://github.com/microsoft/vscode/issues/193110))
 
 ## v1.82 (August 2023)
 

diff --git a/src/ui/requestCDPProxy.ts b/src/ui/requestCDPProxy.ts
@@ -28,19 +28,23 @@ export const registerRequestCDPProxy = (
       }
 
       try {
-        const tunneled = await tunnels.request(sessionId, {
-          label: 'Edge Devtools Tunnel',
-          remotePort: proxied.port,
-        });
+        if (vscode.env.remoteName !== undefined) {
+          const tunneled = await tunnels.request(sessionId, {
+            label: 'Edge Devtools Tunnel',
+            remotePort: proxied.port,
+          });
 
-        return {
-          host: tunneled.localAddress.host,
-          port: tunneled.localAddress.port,
-          path: proxied.path,
-        };
+          return {
+            host: tunneled.localAddress.host,
+            port: tunneled.localAddress.port,
+            path: proxied.path,
+          };
+        }
       } catch {
-        return proxied;
+        // fall through
       }
+
+      return proxied;
     }),
   );
 };