Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Kubeflow Authentication #15862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Kubeflow Authentication #15862

wants to merge 1 commit into from

Conversation

TobiasGoerke
Copy link

Fixes #15659

Use a Jupyter URL that does not return 404 with Jupyter 4.x and thus breaks the authentication.

@TobiasGoerke
Copy link
Author

@DonJayamanne FYI

DonJayamanne
DonJayamanne requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older versions of Jupyter will fail with this change.
We need to be backwards compatible.
I.e. what if users use Jupyter Notebook instad of lab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonJayamanne DonJayamanne DonJayamanne requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubeflow Authentication breaks with JupyterLab 4
2 participants
@TobiasGoerke @DonJayamanne