Add public API event for kernel post-initialization #16214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
reviewed
Nov 8, 2024
| if (!isRemoteConnection(kernel.kernelConnectionMetadata) && execution.executionCount === 0) { | ||
| // For local kernels, execution count must be greater than 0, | ||
| // As we pre-warms kernels (i.e. we start kernels even though the user may not have executed any code). | ||
| // The only way to determine whether users executed code is to look at the execution count |
There was a problem hiding this comment.
We need some check to ensure we do not trigger these events for kernels that are automatically started
Events should be triggered only for kernels that were explicitly started by user
There was a problem hiding this comment.
Please ensure that requirements is still met
There was a problem hiding this comment.
Let me know if the latest iteration based on feedback below addresses this. Thanks!
DonJayamanne
reviewed
Nov 8, 2024
pwang347
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.