-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to install extensions in workbench that fail to install from remote code-server #238815
Conversation
@joshspicer Thanks for the initiation. Instead of adding a new
On the workbench, add a new contribution similar to vscode/src/vs/workbench/contrib/extensions/electron-sandbox/remoteExtensionsInit.ts Line 28 in f0c1f4d
|
956cbd4
to
4cf3940
Compare
If the changes appear safe, you can manually trigger the pipeline by commenting |
src/vs/platform/extensionManagement/common/extensionManagementCLI.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since, I will be not available from tomorrow, I would like to unblock you by giving the approval assuming that you will take care of the review feedback.
Thanks
src/vs/workbench/contrib/extensions/electron-sandbox/installFailedExtensions.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/extensions/electron-sandbox/installFailedExtensions.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/extensionManagement/common/extensionManagement.ts
Outdated
Show resolved
Hide resolved
Provides a way for the remote server to report back to the workbench a set of extensions that it could not install. The workbench will then attempt to install the set of extensions. This is useful in cases when a remote does not have access to the marketplace, but a local machine does. This will effectively proxy the installation of an extension through the user's machine.
…ally to determine failure
267ecc4
to
5a401fa
Compare
changes from last review: 5a401fa |
related: microsoft/vscode-remote-release#9994 , microsoft/vscode-remote-release#5927 (comment) , microsoft/vscode-remote-release#9090 , microsoft/vscode-remote-release#9454 (comment)
Provides a way for the remote server to report back extensions that it could not install. The workbench can read this value and attempt to install these of extensions.
This is useful in cases when a remote does not have access to the marketplace, but a local machine does. This will effectively proxy the installation of an extension through the user's machine, closing several Remote - SSH issues
See demo below showing the end-to-end. This demo uses a modded Remote - SSH that will connect to a server pre-started on my local machine. That server process is blocked from accessing
marketplace.visualstudio.com
, causing an error to be thrown in the serverThe workbench can reach the marketplace and is able to perform the installation.
b73d660:https://github.com/user-attachments/assets/e39e04f1-2ac7-426c-b0e1-53f0905e9ba5