Add brazilian portuguese translation #457
Conversation
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
The clipboard IDs need to be updated for this code to compile.
I'd suggest looking through the accelerator keys to confirm that they are the best choices. Seeing the same key used for multiple menu items seems difficult to use. Part of that was inherited from pt-PT, but this change seems to introduce more, in more common parts of the UI.
The translations themselves seem fine though.
src/lang/res_pt-BR.rc
Outdated
| MENUITEM "&Copiar...\tF8", IDM_COPY | ||
| MENUITEM "S&ymlink...\tF11", IDM_SYMLINK | ||
| MENUITEM "Hardlin&k...\tShift+F11", IDM_HARDLINK | ||
| MENUITEM "Copiar para a Clip&board\tCtrl+C", IDM_COPYTOarea de transferência |
There was a problem hiding this comment.
Looks like an automatic search/replace messed up the ID here
src/lang/res_pt-BR.rc
Outdated
| MENUITEM "Copiar para a Clip&board\tCtrl+C", IDM_COPYTOarea de transferência | ||
| MENUITEM "Cortar para a area de transferência\tCtrl+X", IDM_CUTTOarea de transferência | ||
| MENUITEM "&Colar\tCtrl+V", IDM_PASTE | ||
| MENUITEM "Ex&cluir...\tDel", IDM_DELETE |
There was a problem hiding this comment.
Note this is changing the accelerator key. The menu now has three cs. Windows handles this by having the user press c repeatedly to select them, then pressing Enter to activate, but the experience is messy and I try to avoid overloading like this.
Are you sure using the same key for multiple items is the right thing to do?
src/lang/res_pt-BR.rc
Outdated
| MENUITEM SEPARATOR | ||
| MENUITEM "&Indicar Ramos Expansíveis", IDM_ADDPLUSES | ||
| END | ||
| POPUP "V&er" |
There was a problem hiding this comment.
The original used "Exibir" here - is that better?
src/lang/res_pt-BR.rc
Outdated
| MENUITEM "D&ividir", IDM_SPLIT | ||
| MENUITEM SEPARATOR | ||
| MENUITEM "&Nome", IDM_VNAME | ||
| MENUITEM "&Todos os Detalhes dos Arquivos", IDM_VDETAILS, CHECKED |
There was a problem hiding this comment.
The original used "do Arquivo" here - is that better?
src/lang/res_pt-BR.rc
Outdated
| MENUITEM SEPARATOR | ||
| MENUITEM "Executar &Minimizado", IDM_MINONRUN | ||
| MENUITEM "Criar &Index 'Ir para' ao Ligar", IDM_INDEXONLAUNCH | ||
| MENUITEM "&Salvar Definições ao Sair", IDM_SAVESETTINGS |
There was a problem hiding this comment.
The original used "Configurações" here - is that better?
src/lang/res_pt-BR.rc
Outdated
| MH_MYITEMS+IDM_EDIT, "Editar o item selecionado usando o notepad.exe" | ||
| MH_MYITEMS+IDM_MOVE, "Move o item selecionado" | ||
| MH_MYITEMS+IDM_COPY, "Copia Arquivos e Diretórios" | ||
| MH_MYITEMS+IDM_COPYTOarea de transferência, "Copia um ou mais Arquivos para a area de transferência" |
There was a problem hiding this comment.
This looks like another search/replace messing up the ID
src/lang/suggest_pt-BR.db
Outdated
| SUGGEST( 5, DE_DESTSUBTREE, 0L, \ | ||
| "O diretório de destino é um subdiretório da fonte." ) | ||
| SUGGEST( 6, DE_WINDOWSFILE, 0L, \ | ||
| "arquivo em uso pelo Windows." ) |
There was a problem hiding this comment.
Is this the best capitalization?
|
|
||
| FRAMEMENU MENU | ||
| BEGIN | ||
| POPUP "&Arquivo" |
There was a problem hiding this comment.
This is the same accelerator as used for Ajuda, making opening it with the keyboard a pain. The original used ? instead of Ajuda presumably for this reason. Is there a common convention for representing these two, since both seem very common?
Sending the translation to Brazilian Portuguese, using the pt-PT language files as a base, only changing the few words that differ between the sub-languages.