Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: Zoom.Zoom Manifest Issue for MSI #137286

Open
2 tasks done
PckgrBot opened this issue Jan 31, 2024 · 9 comments
Open
2 tasks done

[Package Issue]: Zoom.Zoom Manifest Issue for MSI #137286

PckgrBot opened this issue Jan 31, 2024 · 9 comments
Labels
Help-Wanted This is a good candidate work item from the community. Installer-Issue Issue with the package's installer. Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@PckgrBot
Copy link
Contributor

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

Zoom manifest is not working correctly, it thinks that the latest version of MSI is installed when the previous version is.

image

image

Steps to reproduce

Install previous version of Zoom MSI

Actual behavior

Reports as latest version installed

Expected behavior

Should show the actual version installed.

Environment

N/A

Screenshots and Logs

No response

@PckgrBot PckgrBot added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jan 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 31, 2024
Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@SpecterShell
Copy link
Contributor

Is it because the manifest (5.17.29988) of this version has a wrong version for the MSI installers?

@stephengillie stephengillie added Help-Wanted This is a good candidate work item from the community. Installer-Issue Issue with the package's installer. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Jan 31, 2024
@PckgrBot
Copy link
Contributor Author

I tested with my own winget repo and when I use the other display version format it seems to understand which version is installed.

I also noticed in the comments field it shows the same version format.

@Trenly any chance you can look at this?

@Trenly
Copy link
Contributor

Trenly commented Jan 31, 2024

@PckgrBot - DisplayVersion must match what is written to control panel exactly in order for the mapping to be correct. I raised PRs for the 2 latest versions to see if it fixes the issue. It seems like many of the older versions also have this issue though, so if the two PR's fix the issue with the latest versions, it would be a good idea to go back and fix the previous manifests

@Trenly
Copy link
Contributor

Trenly commented Feb 1, 2024

Seems theres a bigger issue at play here -

I think we have three options -

  1. Do nothing, and leave the bug as it is
  2. Split the package into Zoom.Zoom.exe and Zoom.Zoom.msi
  3. Remove one of the installer types from the manifest entirely

@SpecterShell
Copy link
Contributor

Seems theres a bigger issue at play here -

* [VersionRange causes issues when packages have multiple DisplayVersion winget-cli#4125](https://github.com/microsoft/winget-cli/issues/4125)

I think we have three options -

1. Do nothing, and leave the bug as it is

2. Split the package into Zoom.Zoom.exe and Zoom.Zoom.msi

3. Remove one of the installer types from the manifest entirely
  1. Change the PackageVersion to the DisplayVersion of MSI installers.

@Trenly
Copy link
Contributor

Trenly commented Feb 1, 2024

  1. Change the PackageVersion to the DisplayVersion of MSI installers.

I considered that, but think that it would still be broken -

@PckgrBot
Copy link
Contributor Author

PckgrBot commented Feb 1, 2024

So will this be remaining a bug?

@SpecterShell
Copy link
Contributor

Well now I prefer to move the MSI installers to a separate package like Zoom.Zoom.MSI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community. Installer-Issue Issue with the package's installer. Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

4 participants