Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Display Version for Zoom.Zoom version 5.17.2.29988 #137363

Closed
wants to merge 1 commit into from

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jan 31, 2024

When the previous version is installed, in sandbox it matches to '> 5.17.5.31030' which indicates the package can't be mapped to a specific version. Making the display version exactly match what is installed should help

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2024-01-31T20:20:37.9667483Z ##[error] Manifest Error: DisplayVersion declared in the manifest has overlap with existing DisplayVersion range in the index. Existing DisplayVersion range in index: [ [5.17.5 (31030), 5.17.5 (31030)]]

(Automated response - build 684.)

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2024-01-31T22:16:48.6603831Z ##[error] Manifest Error: DisplayVersion declared in the manifest has overlap with existing DisplayVersion range in the index. Existing DisplayVersion range in index: [ [5.17.5 (31030), 5.17.5 (31030)]]

(Automated response - build 692.)

@Trenly
Copy link
Contributor Author

Trenly commented Feb 1, 2024

Ah, right. It sees the version ranges as 5.17.2 to 5.17.29988, and that 5.17.5 falls inside that range.

@denelon / @ryfu-msft - This might highlight a need to not treat DisplayVersion as a range and instead make it an array which requires exact matching

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 1, 2024
@JohnMcPMS
Copy link
Member

I agree that there is an issue here with the way that Zoom has done it's versions and we are not able to handle it. For now though, I think we need to revert to using the 1.2.3 (4) version to prevent the current conflict.

@stephengillie
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Manifest-AppsAndFeaturesVersion-Error labels Feb 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 1, 2024
@Trenly Trenly closed this Feb 1, 2024
@Trenly Trenly deleted the ZoomDisplayVersion branch February 1, 2024 20:41
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants