Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest: Microsoft.DotNet.SDK.8 version 8.0.401 #168546

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Aug 21, 2024

What's changed

  • It seems it won't touch Windows Registry while upgrading
  • Try uninstall previous version before installing new one
  • Maybe this can prevent infinite upgrading loop

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

- It seems it won't touch Windows Registry while upgrading
- Try uninstall previous version before installing new one
- Maybe this can prevent infinite upgrading loop

Signed-off-by: Dragon1573 <[email protected]>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Aug 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Aug 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Aug 21, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 21, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit a926992 into microsoft:master Aug 21, 2024
8 checks passed
@Dragon1573 Dragon1573 deleted the issues/168528/8.0.401 branch August 21, 2024 16:55
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@jaliyaudagedara
Copy link

@stephengillie @Dragon1573,

Should the same change be applied for .NET 6 and 7 manifests?

@Dragon1573
Copy link
Contributor Author

Should the same change be applied for .NET 6 and 7 manifests?

Did you validate if this pull request can solve infinite upgrade loop? I can also help porting them to previous major versions.

@jaliyaudagedara
Copy link

yeah, it worked for .NET 8.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Issue]: Microsoft .NET SDK: Upgrade installs the packages, but still says updates are available
4 participants