Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Discord.Discord 1.0.9162 #172176

Closed
wants to merge 1 commit into from
Closed

Conversation

treysis
Copy link
Contributor

@treysis treysis commented Sep 7, 2024

See #172175

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@treysis treysis changed the title Remove until https://github.com/Squirrel/Squirrel.Windows/issues/1187 is fixed. Remove Discord.Discord/1.0.9162 Sep 7, 2024
@treysis treysis changed the title Remove Discord.Discord/1.0.9162 Remove Discord.Discord 1.0.9162 Sep 7, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 7, 2024
@treysis
Copy link
Contributor Author

treysis commented Sep 7, 2024

@stephengillie I think a package that doesn't want to adhere to winget's (and also Windows') logic shouldn't be included in the list. There's not reason in trying to be listed in a package manager that you actually don't support. Whoever wants to use Discord (or any other Squirrel-app for that matter) can use their supported methods of installing and updating.

@Trenly
Copy link
Contributor

Trenly commented Sep 8, 2024

Close with reason: Application should stay in repo;

auto-merge was automatically disabled September 8, 2024 13:47

Pull request was closed

@stephengillie
Copy link
Collaborator

@ stephengillie I think a package that doesn't want to adhere to winget's (and also Windows') logic shouldn't be included in the list. There's not reason in trying to be listed in a package manager that you actually don't support. Whoever wants to use Discord (or any other Squirrel-app for that matter) can use their supported methods of installing and updating.

That's a valid opinion. These should probably be voiced in Issues, to help the community come to a consensus before acting. Were this approved, it might have generated more PRs to readd, creating more work for moderators in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants