Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: vivainio.RoughGrep #182568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vivainio
Copy link

@vivainio vivainio commented Oct 13, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@vivainio
Copy link
Author

@microsoft-github-policy-service agree

@vivainio
Copy link
Author

This implements issue #182569

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Oct 13, 2024
@Dragon1573
Copy link
Contributor

Tip

Modify your very first comment of this pull request as follows, can help linking this pull request to the related issue. When this pull request is successfully merged, the linked issue can also be closed as completed. ❤️

  Checklist for Pull Requests

  - [x] Have you signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs)?
- - [x] Is there a linked Issue?
+ - [x] Resolve #182569

@Dragon1573
Copy link
Contributor

Tip

  1. Your package is published via GitHub Releases.
  2. GitHub Actions is enabled for your source repository.

Are you willing to maintain your package with WinGet Releaser v2? This can simplify your "manifest submission" process and speed up request reviewing and approval.

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\rgg.exe returned exit code: -532462766

Automated error analysis suggests -532462766 may mean EXCEPTION_COMPLUS (Unhandled Exception)

(Automated response - build 896.)

@stephengillie stephengillie added the zip-binary Depends on library files that aren't available via symlink label Oct 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Oct 14, 2024
@stephengillie
Copy link
Collaborator

This application runs, but not from the symlink. Verify while here:
image

@Dragon1573
Copy link
Contributor

Dragon1573 commented Oct 15, 2024

Note

Although adding BurntSushi.ripgrep.MSVC as a Dependencies > PackageDependencies, RoughGrep still unable to launch via symbolic link.

diff --git a/manifests/v/vivainio/RoughGrep/3.14.3/vivainio.RoughGrep.installer.yaml b/manifests/v/vivainio/RoughGrep/3.14.3/vivainio.RoughGrep.installer.yaml
index c3df286b0a1..70110e1605d 100644
--- a/manifests/v/vivainio/RoughGrep/3.14.3/vivainio.RoughGrep.installer.yaml
+++ b/manifests/v/vivainio/RoughGrep/3.14.3/vivainio.RoughGrep.installer.yaml
@@ -8,6 +8,9 @@ NestedInstallerType: portable
 NestedInstallerFiles:
 - RelativeFilePath: RoughGrep\rgg.exe
   PortableCommandAlias: rgg
+Dependencies:
+  PackageDependencies:
+  - PackageIdentifier: BurntSushi.ripgrep.MSVC
 Installers:
 - Architecture: x64
   InstallerUrl: https://github.com/vivainio/RoughGrep/releases/download/v3.14.3/RoughGrep-3.14.3.zip

image
image


📝 Edit

@vivainio - In order to avoid this, are you willing to change your release type to some well-known install wizard format? nullsoft, inno, burn, wix are preferred and encouraged by winget.exe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. New-Package Validation-Executable-Error zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants