-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: vivainio.RoughGrep #182568
base: master
Are you sure you want to change the base?
New package: vivainio.RoughGrep #182568
Conversation
/AzurePipelines run |
@microsoft-github-policy-service agree |
This implements issue #182569 |
Tip Modify your very first comment of this pull request as follows, can help linking this pull request to the related issue. When this pull request is successfully merged, the linked issue can also be closed as completed. ❤️ Checklist for Pull Requests
- [x] Have you signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs)?
- - [x] Is there a linked Issue?
+ - [x] Resolve #182569 |
Tip
Are you willing to maintain your package with WinGet Releaser v2? This can simplify your "manifest submission" process and speed up request reviewing and approval. |
Automatic Validation ended with:
Automated error analysis suggests -532462766 may mean EXCEPTION_COMPLUS (Unhandled Exception) (Automated response - build 896.) |
Note Although adding diff --git a/manifests/v/vivainio/RoughGrep/3.14.3/vivainio.RoughGrep.installer.yaml b/manifests/v/vivainio/RoughGrep/3.14.3/vivainio.RoughGrep.installer.yaml
index c3df286b0a1..70110e1605d 100644
--- a/manifests/v/vivainio/RoughGrep/3.14.3/vivainio.RoughGrep.installer.yaml
+++ b/manifests/v/vivainio/RoughGrep/3.14.3/vivainio.RoughGrep.installer.yaml
@@ -8,6 +8,9 @@ NestedInstallerType: portable
NestedInstallerFiles:
- RelativeFilePath: RoughGrep\rgg.exe
PortableCommandAlias: rgg
+Dependencies:
+ PackageDependencies:
+ - PackageIdentifier: BurntSushi.ripgrep.MSVC
Installers:
- Architecture: x64
InstallerUrl: https://github.com/vivainio/RoughGrep/releases/download/v3.14.3/RoughGrep-3.14.3.zip 📝 Edit@vivainio - In order to avoid this, are you willing to change your release type to some well-known install wizard format? |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow