Skip to content

Commit

Permalink
Narrow down the DataTransferItem types using in operator
Browse files Browse the repository at this point in the history
This is by checking if the  or  instance methods are in the uploadFileItem object. Falsey value is cast to File type

Signed-off-by: Martin Musale <[email protected]>
  • Loading branch information
musale committed Jul 25, 2023
1 parent ec5e666 commit 1d649f3
Showing 1 changed file with 5 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1161,8 +1161,7 @@ export class MgtFileUpload extends MgtBaseComponent {
const collectFilesItems: File[] = [];

for (let uploadFileItem of filesItems) {
const dataTransferItemType = uploadFileItem instanceof DataTransferItem;
const fileType = uploadFileItem instanceof File;
const dataTransferItemType = 'getAsFile' in uploadFileItem || 'webkitGetAsEntry' in uploadFileItem;

if (dataTransferItemType) {
uploadFileItem = uploadFileItem as DataTransferItem;
Expand Down Expand Up @@ -1197,14 +1196,10 @@ export class MgtFileUpload extends MgtBaseComponent {
}
}
continue;
}

if (fileType) {
uploadFileItem = uploadFileItem as File;
if (uploadFileItem) {
this.writeFilePath(uploadFileItem, '');
collectFilesItems.push(uploadFileItem);
}
} else {
const file = uploadFileItem as File;
this.writeFilePath(file, '');
collectFilesItems.push(file);
}
}

Expand Down

0 comments on commit 1d649f3

Please sign in to comment.