feat: add edit funtionality to mgt-todo (#2783)

add edit todo functionality rewrite edit option to apply focus on input element, remove the fluent-checkbox wrapper on todo tasks, fix @keydown function, add Radio svg to fix incomplete checkbox fix dot icon, fix title display add edit date funtionality --------- Co-authored-by: Gavin Barron <[email protected]> Co-authored-by: Musale Martin <[email protected]>
microsoftgraph · Dec 1, 2023 · 64acd1f · 64acd1f
1 parent 59cccb0
commit 64acd1f
Show file tree

Hide file tree

Showing 6 changed files with 342 additions and 153 deletions.
diff --git a/packages/mgt-components/src/components/mgt-todo/mgt-todo.scss b/packages/mgt-components/src/components/mgt-todo/mgt-todo.scss
@@ -17,6 +17,7 @@
     margin-block: 1px;
     box-shadow: $task-box-shadow;
     width: 100%;
+    display: flex;
     background-color: $task-background-color;
 
     &.new-task {
@@ -25,9 +26,15 @@
     }
 
     &.complete {
-      text-decoration: line-through;
       border: 1px solid $task-border-completed;
       background: $task-background-color-completed;
+
+      .task-details {
+        .title,
+        .task-due {
+          text-decoration: line-through;
+        }
+      }
     }
 
     &.read-only {
@@ -47,6 +54,7 @@
       padding: 2px;
       line-height: 24px;
       border-radius: 4px;
+      width: 100%;
 
       .task {
         > div {
@@ -56,12 +64,13 @@
         }
       }
 
-      .title {
-        flex-grow: 1;
+      .task-delete {
+        display: flex;
       }
 
-      .task-delete {
+      .container {
         display: flex;
+        width: 100%;
       }
 
       .task-due {
@@ -70,21 +79,6 @@
         height: 32px;
         text-decoration: inherit;
         display: flex;
-
-        .task-calendar {
-          display: flex;
-          margin-top: 5px;
-          margin-inline-end: 10px;
-
-          svg {
-            fill: $task-color;
-          }
-        }
-
-        .task-due-date {
-          display: flex;
-          margin-top: 5px;
-        }
       }
     }
   }
@@ -132,16 +126,6 @@
             color: $task-color;
             width: auto;
             cursor: pointer;
-
-            &::after {
-              border-bottom: none;
-            }
-
-            &.dark {
-              &::part(control) {
-                color-scheme: dark;
-              }
-            }
           }
 
           input {
@@ -156,16 +140,32 @@
             border-bottom: 1px solid $task-date-input-hover-color;
           }
 
-          input:active {
-            border-bottom: 1px solid $task-date-input-active-color;
-          }
-
+          input:active,
           input:focus {
             border-bottom: 1px solid $task-date-input-active-color;
           }
         }
       }
     }
+
+    &.title {
+      flex-grow: 1;
+      display: inline;
+    }
+
+    &.date {
+      color: $task-detail-color;
+    }
+
+    &::after {
+      border-bottom: none;
+    }
+
+    &.dark {
+      &::part(control) {
+        color-scheme: dark;
+      }
+    }
   }
 
   fluent-button {
@@ -186,38 +186,36 @@
   }
 
   fluent-checkbox {
-    &.task {
-      &.complete {
-        div > svg {
-          .filled {
-            display: block;
-          }
-
-          .regular {
-            display: none;
-          }
-
-          path {
-            fill: $task-radio-background-color;
-          }
-        }
-      }
-
+    &.complete {
       div > svg {
         .filled {
-          display: none;
+          display: block;
         }
 
         .regular {
-          display: block;
+          display: none;
         }
 
         path {
-          fill: $task-background-color;
+          fill: $task-radio-background-color;
         }
       }
     }
 
+    div > svg {
+      .filled {
+        display: none;
+      }
+
+      .regular {
+        display: block;
+      }
+
+      path {
+        fill: $task-background-color;
+      }
+    }
+
     &::part(control) {
       margin-inline-start: 10px;
       background: none;

diff --git a/packages/mgt-components/src/components/mgt-todo/mgt-todo.tests.ts b/packages/mgt-components/src/components/mgt-todo/mgt-todo.tests.ts
@@ -0,0 +1,21 @@
+/**
+ * -------------------------------------------------------------------------------------------
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
+ * -------------------------------------------------------------------------------------------
+ */
+
+import { expect } from '@open-wc/testing';
+import { MockProvider, Providers } from '@microsoft/mgt-element';
+import { MgtTodo, registerMgtTodoComponent } from './mgt-todo';
+
+describe('mgt-todo - tests', () => {
+  before(() => {
+    registerMgtTodoComponent();
+    Providers.globalProvider = new MockProvider();
+  });
+
+  it('has required scopes', () => {
+    expect(MgtTodo.requiredScopes).to.have.members(['tasks.readwrite', 'tasks.read']);
+  });
+});