Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ac11y): unset custom color of storybook left chevrons to fix contrast #2595

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jul 11, 2023

Closes #2317

PR Type

Bugfix

Description of the changes

Unset custom color of storybook left expanded/collapsed chevrons to fix contrast

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner July 11, 2023 12:29
@ghost
Copy link

ghost commented Jul 11, 2023

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron enabled auto-merge (squash) July 11, 2023 18:34
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron merged commit 764bf12 into main Jul 12, 2023
7 checks passed
@gavinbarron gavinbarron deleted the ac11y-2317 branch July 12, 2023 08:19
@vagpt
Copy link
Collaborator

vagpt commented Jul 12, 2023

Hi @gavinbarron

While opening the above-mentioned URL, we are getting the error below.

image

@vagpt
Copy link
Collaborator

vagpt commented Mar 11, 2024

Hi @gavinbarron

Hope you are doing great.

Could you please provide us updated URL to verify this issue as the mentioned URL in PR is not working.

@gavinbarron
Copy link
Member

The changes here are in main, you can retest this on https://mgt.dev

@vagpt
Copy link
Collaborator

vagpt commented Mar 15, 2024

Hi @gavinbarron,

This issue is still repro on the environment below, hence reactivating this issue.

Test Environment:
URL: https://mgt.dev/?path=/docs/overview--docs
OS Version: 24H2 (OS Build 26063.1)
Browser Version: Edge Dev 124.0.2450.2
Tool: Accessibility Insight For Windows

Snippet:

Issue is still repro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants