chore: release main #2611
Closed
chore: release main #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbarron
force-pushed
the
release-please/branches/main
branch
from
0b6d1a1
to
ad126b9
Compare
|
Thank you for creating a Pull Request @gavinbarron. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
gavinbarron
commented
Jul 18, 2023
| @@ -2,6 +2,24 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. | |||
|
|
|||
| ### [3.0.1](https://www.github.com/microsoftgraph/microsoft-graph-toolkit/compare/root-v3.0.0...root-v3.0.1) (2023-07-18) | |||
There was a problem hiding this comment.
This is generated incorrectly and should not have the root- prefixes on in the tag names
There was a problem hiding this comment.
Same thing happens to the PR content that has root: 3.0.1 as the top element. Do we need that?
There was a problem hiding this comment.
I believe this is a bug as there is an include-component-in-tag setting that should set the tag for the release to v{{SemVer}} when it is false.
I've opened an issue on the action repo, https://github.com/google-github-actions/release-please-action/issues/796
|
closing in favor of #2615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release *beep* *boop*
root: 3.0.1
Bug Fixes
InAConferenceCallactivity when availability isBusy(#2585) (bd17195)This PR was generated with Release Please. See documentation.