Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update README docs for mgt packages #2626

Merged
merged 6 commits into from
Jul 27, 2023
Merged

chore(docs): update README docs for mgt packages #2626

merged 6 commits into from
Jul 27, 2023

Conversation

musale
Copy link
Contributor

@musale musale commented Jul 24, 2023

Closes #2570

PR Type

  • Bugfix

Description of the changes

  • Updates the components list for mgt v3
  • Updates the providers list for mgt v3

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Signed-off-by: Martin Musale <[email protected]>
@musale musale added this to the 2023-07 milestone Jul 24, 2023
@musale musale requested a review from a team as a code owner July 24, 2023 09:23
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@sebastienlevert
Copy link
Contributor

@musale I would love to see all packages (mgt-compoentns, etc.) to be updated also.

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to have the components list in pacakges/mgt-components updated too

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Jul 24, 2023
@musale musale changed the title docs: update README docs for mgt package chore(docs): update README docs for mgt packages Jul 25, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Jul 25, 2023
@gavinbarron gavinbarron enabled auto-merge (squash) July 27, 2023 21:35
@gavinbarron gavinbarron merged commit a0ce2f4 into main Jul 27, 2023
7 checks passed
@gavinbarron gavinbarron deleted the bug-2570 branch July 27, 2023 21:46
gavinbarron added a commit that referenced this pull request Aug 21, 2023
Update README docs for mgt
Update the README docs for mgt-components
Add links to mgt-picker component

---------

Signed-off-by: Martin Musale <[email protected]>
Co-authored-by: Gavin Barron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DOCS] README.md from our npm packages haven't been updated with v3 components and providers.
4 participants