Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all samples except react-contoso #2627

Merged
merged 4 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,3 @@ package-lock.json
storybook-static/
custom-elements.json
workbench.html

!/samples/teamsfx-app/.vscode
12 changes: 1 addition & 11 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
{
"packages": [
"packages/*",
"packages/providers/*",
"samples/react-contoso",
"samples/react-app",
"samples/angular-app",
"samples/vue-app",
"samples/electron-app",
"samples/sp-webpart",
"samples/sp-mgt"
],
"packages": ["packages/*", "packages/providers/*", "samples/react-contoso"],
"npmClient": "yarn",
"version": "independent"
}
15 changes: 2 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,7 @@
"packages": [
"packages/*",
"packages/providers/*",
"samples/react-contoso",
"samples/react-app",
"samples/angular-app",
"samples/vue-app",
"samples/electron-app",
"samples/sp-webpart",
"samples/sp-mgt",
"samples/teamsfx-app"
"samples/react-contoso"
],
"nohoist": [
"**/@microsoft/sp-office-ui-fabric-core**",
Expand All @@ -31,11 +24,7 @@
"build:mgt-components": "cd ./packages/mgt-components && npm run build",
"build:mgt-react": "lerna run build --scope @microsoft/mgt-react",
"build:mgt-spfx": "lerna run build --scope @microsoft/mgt-spfx",
"build:sp-webpart": "lerna run build --scope mgt-demo",
"build:sp-mgt": "lerna run build --scope sp-mgt-no-framework",
"build:react-contoso": "lerna run build --scope react-contoso",
"package:sp-webpart": "lerna run package --scope mgt-demo",
"package:sp-mgt": "lerna run package --scope sp-mgt-no-framework",
"bundle": "cd ./packages/mgt && npm run bundle",
"clean": "lerna run --parallel --stream --scope @microsoft/* clean",
"lint:eslint": "eslint -c .eslintrc.js --quiet 'packages/*/src/**/*.ts'",
Expand Down Expand Up @@ -162,4 +151,4 @@
"resolutions": {
"responselike": "2.0.0"
}
}
}
18 changes: 1 addition & 17 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</p>

<p align="center">
<a href="#packages">Packages</a> • <a href="#components">Components</a> • <a href="#providers">Providers</a> • <a href="#getting-started">Getting Started</a> • <a href="#running-the-samples">Running the Samples</a> • <a href="#contribute">Contribute</a> • <a href="#feedback-and-requests">Feedback & Requests</a> <br>• <a href="#license">License</a> • <a href="#code-of-conduct">Code of Conduct</a>
sebastienlevert marked this conversation as resolved.
Show resolved Hide resolved
<a href="#packages">Packages</a> • <a href="#components">Components</a> • <a href="#providers">Providers</a> • <a href="#getting-started">Getting Started</a> • <a href="#contribute">Contribute</a> • <a href="#feedback-and-requests">Feedback & Requests</a> <br>• <a href="#license">License</a> • <a href="#code-of-conduct">Code of Conduct</a>
</p>

## Packages
Expand Down Expand Up @@ -143,22 +143,6 @@ Now you can reference all components and providers at the page you are using:
<mgt-agenda></mgt-agenda>
```

## Running the samples

Some of our samples are coupled to use the locally built mgt packages instead of the published version from npm. Because of this, it's helpful to build the monorepo before attempting to run any of the samples.

```bash
# Starting at the root
yarn
yarn build
# Now you can run the React sample using the local packages
cd ./samples/react-app/
yarn start
```

This also means that running the samples in isolation may fail if there are breaking changes between the published version of mgt and the local copy.
To workaround this, use samples that are known to be compatible with a specific release by checking out the appropriate branch or tag first.

## Contribute

We enthusiastically welcome contributions and feedback. Please read our [wiki](https://github.com/microsoftgraph/microsoft-graph-toolkit/wiki) and the [contributing guide](CONTRIBUTING.md) before you begin.
Expand Down
16 changes: 0 additions & 16 deletions samples/angular-app/.editorconfig

This file was deleted.

48 changes: 0 additions & 48 deletions samples/angular-app/.gitignore

This file was deleted.

24 changes: 0 additions & 24 deletions samples/angular-app/README.md

This file was deleted.

115 changes: 0 additions & 115 deletions samples/angular-app/angular.json

This file was deleted.

12 changes: 0 additions & 12 deletions samples/angular-app/browserslist

This file was deleted.

32 changes: 0 additions & 32 deletions samples/angular-app/e2e/protractor.conf.js

This file was deleted.

23 changes: 0 additions & 23 deletions samples/angular-app/e2e/src/app.e2e-spec.ts

This file was deleted.

11 changes: 0 additions & 11 deletions samples/angular-app/e2e/src/app.po.ts

This file was deleted.

13 changes: 0 additions & 13 deletions samples/angular-app/e2e/tsconfig.json

This file was deleted.

Loading
Loading