Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(main): release 3.1.0 #2628

Merged
merged 1 commit into from
Jul 31, 2023
Merged

chore(main): release 3.1.0 #2628

merged 1 commit into from
Jul 31, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Jul 24, 2023 •
edited
Loading

🤖 I have created a release beep boop

3.1.0 (2023-07-28)

Features

  • add canary url to allowed endpoints for graph (#2635) (ec621cd)

Bug Fixes

  • a11y: add distinct name definitions for copy code buttons in storybook overview (#2622) (4e52f41)
  • add a title text if displaying images only. (#2625) (28703c9)
  • check the file type being uploaded before performing upload (#2584) (7fb265c)
  • remove agenda tooltip (#2621) (27e1fc9)

This PR was generated with Release Please. See documentation.

@gavinbarron gavinbarron requested a review from a team as a code owner July 24, 2023 22:41
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron
Copy link
Member Author

We should probably put fixes that improve the a11y of the Storybook site as either chores or docs to prevent them triggering releases in the future....

@sebastienlevert
Copy link
Contributor

To understand better... Are the release automatically created (and updated) as we PR to main?

@gavinbarron gavinbarron force-pushed the release-please--branches--main--components--root branch from 3b3d44a to 557cfe5 Compare July 25, 2023 15:58
@gavinbarron
Copy link
Member Author

Correct, when there is a commit/push on main the workflow with the release-please action is run
This inspects the commits since the last release and determines based on conventional commits if a release is needed to ship changes.
If there are fix or feat commits a PR is raised targeting main. The PR contains the updated changelog, incremented version numbers in the manifest and package.json and a tag with the next release version.

When this PR is approved and merged to main, sidenote here, but we should be using squash merges in almost every case, then the release workflow gets kicked off to build and publish the npm packages while this workflow creates the GitHub release with the tag.

@gavinbarron gavinbarron force-pushed the release-please--branches--main--components--root branch 2 times, most recently from 27600e3 to 77c2974 Compare July 27, 2023 15:59
@gavinbarron gavinbarron enabled auto-merge (squash) July 27, 2023 16:39
@gavinbarron gavinbarron force-pushed the release-please--branches--main--components--root branch 2 times, most recently from ce22e59 to 93a8082 Compare July 28, 2023 08:35
@gavinbarron gavinbarron changed the title chore(main): release 3.0.2 chore(main): release 3.1.0 Jul 28, 2023
@gavinbarron gavinbarron force-pushed the release-please--branches--main--components--root branch from 93a8082 to a7ed92b Compare July 28, 2023 17:12
musale
musale approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

sebastienlevert
sebastienlevert approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll merge!

@sebastienlevert sebastienlevert merged commit a6900c2 into main Jul 31, 2023
7 checks passed
@sebastienlevert sebastienlevert deleted the release-please--branches--main--components--root branch July 31, 2023 17:49
@gavinbarron
Copy link
Member Author

🤖 Release is at https://github.com/microsoftgraph/microsoft-graph-toolkit/releases/tag/v3.1.0 🌻

gavinbarron added a commit that referenced this pull request Aug 21, 2023
@gavinbarron
chore(main): release 3.1.0 (#2628)
e3628e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@musale musale musale approved these changes

Assignees
No one assigned
Labels
autorelease: tagged
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavinbarron @sebastienlevert @musale