Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix the order of stories in the playground #2645

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

musale
Copy link
Contributor

@musale musale commented Aug 3, 2023

Closes #2643

PR Type

  • Bugfix

Description of the changes

Fixed the order of stories in the playground.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

When we move to version 7+, this will be updated to mgt-component.js from mgt-component.stories.js

Signed-off-by: Musale Martin <[email protected]>
@musale musale requested a review from a team as a code owner August 3, 2023 12:04
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

The updated storybook is available here

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works great! Thanks for this! @musale do you know how we could ship this without releasing? 🤔

@sebastienlevert sebastienlevert merged commit 4104a8a into main Aug 3, 2023
8 checks passed
@sebastienlevert sebastienlevert deleted the fix-story-order branch August 3, 2023 16:16
gavinbarron pushed a commit that referenced this pull request Aug 21, 2023
* Change the story file name to include stories

When we move to version 7+, this will be updated to mgt-component.js from mgt-component.stories.js

Signed-off-by: Musale Martin <[email protected]>

* Order options to start with stories files

Signed-off-by: Musale Martin <[email protected]>

* Update pages that the theme toggle should not appear on

Signed-off-by: Musale Martin <[email protected]>

---------

Signed-off-by: Musale Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt.dev ordering of stories is different since 3.1.0
2 participants