Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable open on click behavior #2685

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Aug 25, 2023

Adds the disable-open-on-click attibute to the mgt-file-list to allow developers to prevent items with a webUrl from opening in a new browser window. The provides backwards function compatibility to v2

Closes #2670

PR Type

  • Bugfix

Description of the changes

PR checklist

  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Adds the disable-open-on-click attibute to the mgt-file-list to allow developers to prevent items with a webUrl from opening in a new browser window. The provides backwards function compatibility to v2
@gavinbarron gavinbarron requested a review from a team as a code owner August 25, 2023 21:02
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

The updated storybook is available here

@sebastienlevert
Copy link
Contributor

I would modify the Events story also to add the disable-open-on-click as the way it's happening now, we lose the focus and it's weird...

@gavinbarron
Copy link
Member Author

Great suggestion, thanks @sebastienlevert :)

@github-actions
Copy link

The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-file-list always opens clicked item in new tab
3 participants