Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a shimmer for the loading state of person component #3009

Merged
merged 8 commits into from
Mar 7, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Feb 1, 2024

Closes #797

PR Type

Description of the changes

Adds a shimmer for the loading state in mgt-person

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Copy link

github-actions bot commented Feb 1, 2024

🚀 New react-contoso sample application deployed here

2 similar comments
Copy link

github-actions bot commented Feb 1, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 1, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 1, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Feb 1, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 1, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Feb 2, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 2, 2024

📖 The updated storybook is available here

@musale musale marked this pull request as ready for review February 12, 2024 06:52
@musale musale requested a review from a team as a code owner February 12, 2024 06:52
Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

Copy link

📖 The updated storybook is available here

Copy link

🚀 New react-contoso sample application deployed here

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shimmer should have the same shape and size as the person based on the configuration of the component.

Copy link

github-actions bot commented Mar 5, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Mar 5, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Mar 5, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 82% 100% 0
mgt-components.src.components.mgt-person-card 77% 49% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 77% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 67% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 100% 0
mgt-element.src.utils 71% 90% 0
Summary 67% (14504 / 21520) 74% (518 / 698) 0

gavinbarron

This comment was marked as resolved.

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[mgt-person] render placeholder while loading/fetching data
3 participants