Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply keyboard focus when removing selected person or adding person from suggestion list on people-picker #3011

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Feb 1, 2024

Closes #2342

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner February 1, 2024 15:42
Copy link

github-actions bot commented Feb 1, 2024

📖 The updated storybook is available here

1 similar comment
Copy link

github-actions bot commented Feb 1, 2024

📖 The updated storybook is available here

sebastienlevert
sebastienlevert previously approved these changes Feb 1, 2024
Copy link

github-actions bot commented Feb 2, 2024

📖 The updated storybook is available here

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mnickii I'm facing an issue with the single select mode. When I add a person, the cursor is blinking despite showing that "max contacts added". Also, I'm able to type in the input. This should be disabled, and the cursor should not be blinking in single select mode.

Copy link

github-actions bot commented Feb 5, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Feb 5, 2024

📖 The updated storybook is available here

@Mnickii Mnickii requested a review from musale February 5, 2024 11:10
musale
musale previously approved these changes Feb 5, 2024
@musale
Copy link
Contributor

musale commented Feb 5, 2024

@vagpt this is ready for review

Copy link

github-actions bot commented Feb 5, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Feb 7, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Feb 7, 2024

📖 The updated storybook is available here

@gavinbarron
Copy link
Member

@Raisul123 I believe this change resolves the associated issue

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 84% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 71% 0
mgt-components.src.components.mgt-person-card 67% 48% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 67% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 86% 78% 0
mgt-element.src.providers 83% 92% 0
mgt-element.src.utils 72% 91% 0
Summary 66% (14210 / 21454) 67% (454 / 680) 0

Copy link

📖 The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants