Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update contoso app to use migration shims components #3015

Merged
merged 6 commits into from
Feb 12, 2024
Merged

fix: update contoso app to use migration shims components #3015

merged 6 commits into from
Feb 12, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Feb 2, 2024

Closes #3014

PR Type

  • Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the Chat - GA milestone Feb 2, 2024
@musale musale requested a review from a team as a code owner February 2, 2024 12:22
@musale musale linked an issue Feb 2, 2024 that may be closed by this pull request
BUG: CSS is missing fluent UI tokens in Contoso chat view #3014
Closed
@musale musale changed the title fix: update contoso app to use migration shims fix: update contoso app to use migration shims components Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

🚀 New react-contoso sample application deployed here

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

🚀 New react-contoso sample application deployed here

gavinbarron
gavinbarron previously approved these changes Feb 2, 2024
View reviewed changes
@musale musale force-pushed the fix/react-northstar-theming branch from e3ff347 to 4439de0 Compare February 8, 2024 11:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-chat.src.statefulClient 100% 100% 0 ✔
mgt-chat.src.utils 100% 86% 0 ✔
mgt-components.dist.es6.components.mgt-agenda.src.components.mgt-agenda 14% 100% 0 ❌
mgt-components.dist.es6.components.mgt-contact.src.components.mgt-contact 62% 100% 0 ➖
mgt-components.dist.es6.components.mgt-file-list.mgt-file-upload.src.components.mgt-file-list.mgt-file-upload 43% 100% 0 ❌
mgt-components.dist.es6.components.mgt-file-list.src.components.mgt-file-list 62% 100% 0 ➖
mgt-components.dist.es6.components.mgt-file.src.components.mgt-file 61% 100% 0 ➖
mgt-components.dist.es6.components.mgt-get.src.components.mgt-get 19% 100% 0 ❌
mgt-components.dist.es6.components.mgt-login.src.components.mgt-login 64% 100% 0 ➖
mgt-components.dist.es6.components.mgt-messages.src.components.mgt-messages 66% 100% 0 ➖
mgt-components.dist.es6.components.mgt-organization.src.components.mgt-organization 46% 100% 0 ❌
mgt-components.dist.es6.components.mgt-people-picker.src.components.mgt-people-picker 56% 100% 0 ➖
mgt-components.dist.es6.components.mgt-people.src.components.mgt-people 72% 100% 0 ➖
mgt-components.dist.es6.components.mgt-person-card.src.components.mgt-person-card 59% 33% 0 ➖
mgt-components.dist.es6.components.mgt-person.src.components.mgt-person 53% 100% 0 ➖
mgt-components.dist.es6.components.mgt-picker.src.components.mgt-picker 78% 100% 0 ✔
mgt-components.dist.es6.components.mgt-planner.src.components.mgt-planner 55% 100% 0 ➖
mgt-components.dist.es6.components.mgt-profile.src.components.mgt-profile 39% 100% 0 ❌
mgt-components.dist.es6.components.mgt-search-box.src.components.mgt-search-box 83% 100% 0 ✔
mgt-components.dist.es6.components.mgt-search-results.src.components.mgt-search-results 56% 100% 0 ➖
mgt-components.dist.es6.components.mgt-tasks-base.src.components.mgt-tasks-base 86% 100% 0 ✔
mgt-components.dist.es6.components.mgt-taxonomy-picker.src.components.mgt-taxonomy-picker 74% 100% 0 ➖
mgt-components.dist.es6.components.mgt-teams-channel-picker.src.components.mgt-teams-channel-picker 62% 100% 0 ➖
mgt-components.dist.es6.components.mgt-theme-toggle.src.components.mgt-theme-toggle 74% 100% 0 ➖
mgt-components.dist.es6.components.mgt-todo.src.components.mgt-todo 78% 100% 0 ✔
mgt-components.dist.es6.components.src.components 86% 100% 0 ✔
mgt-components.dist.es6.components.sub-components.mgt-arrow-options.src.components.sub-components.mgt-arrow-options 76% 100% 0 ✔
mgt-components.dist.es6.components.sub-components.mgt-dot-options.src.components.sub-components.mgt-dot-options 29% 100% 0 ❌
mgt-components.dist.es6.components.sub-components.mgt-flyout.src.components.sub-components.mgt-flyout 40% 100% 0 ❌
mgt-components.dist.es6.components.sub-components.mgt-spinner.src.components.sub-components.mgt-spinner 92% 100% 0 ✔
mgt-components.dist.es6.graph.src.graph 36% 100% 0 ❌
mgt-components.dist.es6.src 100% 100% 0 ✔
mgt-components.dist.es6.styles.src.styles 73% 100% 0 ➖
mgt-components.dist.es6.utils.src.utils 46% 100% 0 ❌
mgt-components.src.components 84% 75% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 46% 100% 0 ❌
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 84% 76% 0 ✔
mgt-components.src.components.mgt-person-card 67% 48% 0 ➖
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0 ➖
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 40% 73% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 82% 46% 0 ✔
mgt-element.dist.es6.components.src.components 72% 74% 0 ➖
mgt-element.dist.es6.mock.src.mock 91% 77% 0 ✔
mgt-element.dist.es6.providers.src.providers 87% 83% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 67% 73% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 83% 91% 0 ✔
mgt-element.src.utils 71% 90% 0 ➖
Summary 60% (27973 / 46496) 70% (554 / 787) 0 ➖

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

🚀 New react-contoso sample application deployed here

@gavinbarron gavinbarron merged commit 5c123b0 into next/mgt-chat Feb 12, 2024
10 checks passed
@gavinbarron gavinbarron deleted the fix/react-northstar-theming branch February 12, 2024 15:13
plasne added a commit to plasne/microsoft-graph-toolkit that referenced this pull request Feb 21, 2024
@plasne
Merge pull request #66 from plasne/microsoftgraph-next/mgt-chat
b48c889 
fix: update contoso app to use migration shims components (microsoftgraph#3015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

Assignees
No one assigned
Labels
Build: React Contoso
Projects
Graph Toolkit
Archived in project
Milestone
Chat - GA
Development

Successfully merging this pull request may close these issues.

BUG: CSS is missing fluent UI tokens in Contoso chat view
2 participants
@musale @gavinbarron