Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate sample app to vite #3038

Merged
merged 3 commits into from
Feb 13, 2024
Merged

chore: migrate sample app to vite #3038

merged 3 commits into from
Feb 13, 2024

Conversation

gavinbarron
Copy link
Member

Closes #3037

PR Type

  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes

Description of the changes

Removes use of react-scripts and moves to use vite for build and developing the react sample app

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Copy link

🚀 New react-contoso sample application deployed here

musale
musale previously approved these changes Feb 13, 2024
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding http://127.0.0.1:3000/ to the list of redirect URI for the app.

Copy link

🚀 New react-contoso sample application deployed here

Mnickii
Mnickii previously approved these changes Feb 13, 2024
@gavinbarron gavinbarron dismissed stale reviews from Mnickii and musale via 08c7e04 February 13, 2024 19:45
@gavinbarron gavinbarron enabled auto-merge (squash) February 13, 2024 19:45
Copy link

🚀 New react-contoso sample application deployed here

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 84% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 71% 0
mgt-components.src.components.mgt-person-card 67% 48% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 90% 72% 0
mgt-element.dist.es6.providers.src.providers 85% 73% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 67% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 66% (14185 / 21454) 66% (448 / 679) 0

Copy link
Contributor

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gavinbarron gavinbarron merged commit db77c4c into main Feb 13, 2024
10 checks passed
@gavinbarron gavinbarron deleted the chore/retire-cra branch February 13, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants