-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate sample app to vite #3038
Conversation
🚀 New react-contoso sample application deployed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding http://127.0.0.1:3000/ to the list of redirect URI for the app.
🚀 New react-contoso sample application deployed here |
🚀 New react-contoso sample application deployed here |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Closes #3037
PR Type
Description of the changes
Removes use of react-scripts and moves to use vite for build and developing the react sample app
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information