Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add permissions for CodeQL #3041

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix: add permissions for CodeQL #3041

merged 3 commits into from
Feb 13, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Feb 13, 2024

Closes #3034

PR Type

  • Bugfix

Description of the changes

Added a permissions block with necessary permissions for code ql jobs.
Updated to code ql v3.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

BEGIN_COMMIT_OVERRIDE
chore: add permissions for CodeQL (#3041)

Add permissions to allow codeql to run
Update to codeql v3
END_COMMIT_OVERRIDE

@musale musale added this to the v4.1.0 milestone Feb 13, 2024
@musale musale requested a review from a team as a code owner February 13, 2024 10:13
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 85% 67% 0
mgt-components.src.components.mgt-contact 63% 100% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 72% 0
mgt-components.src.components.mgt-person-card 55% 57% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 78% 12% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 67% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 65% (13951 / 21454) 66% (418 / 636) 0

@gavinbarron gavinbarron enabled auto-merge (squash) February 13, 2024 17:48
@gavinbarron gavinbarron merged commit f84d6ef into main Feb 13, 2024
9 checks passed
@gavinbarron gavinbarron deleted the fix/update-codeql-perms branch February 13, 2024 17:51
@gavinbarron
Copy link
Member

gavinbarron commented Feb 14, 2024

Heads up @musale and @Mnickii, I merged this with the fix type in the commit header. This causes release-please to treat this as a releasable unit, it's not.

I should have edited the commit to be:

chore: add permissions for CodeQL (#3041)

Add permissions to allow codeql to run
Update to codeql v3

luckily release-please allows for us to fix this by editing the PR message to include an override, so take a look up at the PR entry to see how I corrected my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] CodeQL job is failing
3 participants