Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add aria-label text string for teams chevrons #3129

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Mar 5, 2024

Closes #3050

PR Type

  • Bugfix

Description of the changes

Adds 2 aria label strings for chevron up and down buttons.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale requested a review from a team as a code owner March 5, 2024 14:16
Copy link

github-actions bot commented Mar 5, 2024

📖 The updated storybook is available here

@sebastienlevert
Copy link
Contributor

I can't close opened teams now. Is this a defect from this PR now?

@musale
Copy link
Contributor Author

musale commented Mar 5, 2024

I can't close opened teams now. Is this a defect from this PR now?

I don't think so. Is it different behavior from mgt.dev?

Copy link

github-actions bot commented Mar 7, 2024

📖 The updated storybook is available here

@gavinbarron
Copy link
Member

@Raisul123 could you please validate this fix?

Copy link

github-actions bot commented Mar 8, 2024

📖 The updated storybook is available here

Copy link

📖 The updated storybook is available here

@Raisul123
Copy link
Collaborator

Hi @gavinbarron ,

This issue not repro on below URL
The updated storybook is available here (https://mgt.dev/next/pr/3129)

PFA
image

@gavinbarron
Copy link
Member

@Raisul123 can you offer any insight as to why adding the aria-label does not resolve this issue>

@vagpt
Copy link
Collaborator

vagpt commented Mar 27, 2024

@Raisul123 can you offer any insight as to why adding the aria-label does not resolve this issue>

Hi @gavinbarron,

We have added tag A11yTTValidated on #3050 which is related to this PR also, same reference was provide by Raisul on this PR as well.

Please let me know if you need any help on this PR.

@gavinbarron
Copy link
Member

@Raisul123 and @vagpt, my apologies, I mis-read your comment.

@gavinbarron gavinbarron enabled auto-merge (squash) March 27, 2024 17:55
@gavinbarron gavinbarron merged commit bc1fedf into main Mar 27, 2024
9 checks passed
@gavinbarron gavinbarron deleted the a11y/fix-btn-chevron branch March 27, 2024 18:10
Copy link

📖 The updated storybook is available here

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 82% 100% 0
mgt-components.src.components.mgt-person-card 77% 49% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 77% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 68% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 84% 100% 0
mgt-element.src.utils 72% 91% 0
Summary 67% (14551 / 21559) 74% (523 / 703) 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG ]WCAG 4.1.2: Ensures buttons have discernible text (mgt-teams-channel-picker,.down-chevron,button)
6 participants