Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): correctly narrate tab status in storybook editor #3220

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jun 13, 2024

Closes #3077

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner June 13, 2024 07:47
Copy link
Contributor

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@Mnickii
Copy link
Collaborator Author

Mnickii commented Jun 13, 2024

@gavinbarron, your comments 1 and 2 are resolved in this PR

@Mnickii
Copy link
Collaborator Author

Mnickii commented Jun 13, 2024

Hi @Raisul123 , @vagpt , this is ready for review

@vagpt
Copy link
Collaborator

vagpt commented Jun 13, 2024

This issue is working as expected, hence we are good to close the issue related to this PR.

URL: https://mgt.dev/next/pr/3220/?path=/story/editor--editor

Attachment:

Untitled.video.-.Made.with.Clipchamp.33.mp4

Copy link

📖 The updated storybook is available here

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Mnickii Mnickii merged commit 7932f55 into main Jun 13, 2024
11 checks passed
@Mnickii Mnickii deleted the fix/bug-3077 branch June 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants