Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display only a person's shared files in mgt-person-card #3238

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jun 26, 2024

Closes #3232

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner June 26, 2024 16:40
Copy link
Contributor

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@Mnickii Mnickii requested a review from musale June 27, 2024 11:32
musale
musale previously approved these changes Jun 28, 2024
Copy link

github-actions bot commented Jul 1, 2024

📖 The updated storybook is available here

Copy link

sonarcloud bot commented Jul 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
49.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Mnickii Mnickii merged commit da90c5b into main Jul 1, 2024
10 of 11 checks passed
@Mnickii Mnickii deleted the fix/bug-3232 branch July 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Person card - Navigating to another user shows the same files
3 participants