Skip to content

Commit

Permalink
breaking: Change to websocket v5 (#22)
Browse files Browse the repository at this point in the history
* fix: gitignore now ignores the correct build directory and .midiMixerPlugin files

* fix: Updated midi-mixer-cli/plugin packages and added bundledDependencies to properly pack

* fix: remove cached tracked output file

* feat: Upgrade to websocket version 5

BREAKING CHANGE: Updated package not compatible with websocket version 4.x

* feat: Add audio meters

* remove test code

* docs: Update PAGE.md indicating websocket v5

* fix: prepend 'ws://' if address does not start with it

* fix: duh, wrong operator

* Add scaling value for meters

* remove simple attempt at retrying on connection failed
  • Loading branch information
Jaggernaut555 authored and jpwilliams committed Oct 9, 2022
1 parent 85ed500 commit f7c1a92
Show file tree
Hide file tree
Showing 5 changed files with 232 additions and 120 deletions.
2 changes: 2 additions & 0 deletions PAGE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## This Requires the OBS Websocket version 5

# OBS Plugin

A proof-of-concept plugin that provides very basic OBS integration.
156 changes: 100 additions & 56 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
"dependencies": {
"midi-mixer-plugin": "^1.0.2",
"obs-websocket-js": "^4.0.2",
"obs-websocket-js": "^5.0.2",
"ws": "8.4.0"
},
"bundledDependencies": [
Expand All @@ -45,7 +45,12 @@
],
"volta": {
"node": "14.15.4",
"npm": "6.14.11"
"npm": "8.19.2"
},
"version": "0.1.6"
"version": "0.1.6",
"bundleDependencies": [
"midi-mixer-plugin",
"obs-websocket-js",
"ws"
]
}
7 changes: 6 additions & 1 deletion plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"label": "OBS WebSocket Address",
"required": false,
"type": "text",
"fallback": "localhost:4444"
"fallback": "ws://localhost:4455"
},
"password": {
"label": "OBS WebSocket Password",
Expand All @@ -27,6 +27,11 @@
"reconnect": {
"label": "Reconnect",
"type": "button"
},
"meterMultiplier": {
"label": "Meter Scaling Multiplier",
"type": "text",
"fallback": "1"
}
}
}
Loading

0 comments on commit f7c1a92

Please sign in to comment.