-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): createRequestParamDecorator default support throw error #3656
base: main
Are you sure you want to change the base?
feat(core): createRequestParamDecorator default support throw error #3656
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3656 +/- ##
==========================================
- Coverage 84.55% 82.79% -1.76%
==========================================
Files 491 491
Lines 46778 46766 -12
Branches 5601 5164 -437
==========================================
- Hits 39551 38722 -829
- Misses 7191 8021 +830
+ Partials 36 23 -13 ☔ View full report in Codecov by Sentry. |
transform, | ||
pipesOrOptions.pipes | ||
); | ||
if (pipesOrOptions.throwError == null) pipesOrOptions.throwError = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里还是 breaking 了,可以合到 4.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以的,先发你之前的小Patch吧
这个 issue 和以下问题是同一个问题吗?
|
…m_decorator_throw_error # Conflicts: # packages/core/src/decorator/web/paramMapping.ts
this PR can merge @czy88840616 |
我依稀记得是装饰器里面抛错,throw不出来 |
现在 main 还是 v3 啊 |
No description provided.