Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First cut of refactor #6

Merged
merged 1 commit into from
Apr 23, 2018
Merged

First cut of refactor #6

merged 1 commit into from
Apr 23, 2018

Conversation

midwire
Copy link
Owner

@midwire midwire commented Apr 21, 2018

  • I wrote specs to cover new or modified code in this PR
  • I ran rake spec locally and ALL specs pass

Related Issue: #5
Description: First cut of refactor. I have not written specs yet but I tested it locally with allCountries and US. It is much faster, thanks to @firien’s PR #1 with the idea to use in-memory SQLite databases.

Here’s an overview of what I did:

  • Made it a gem with a command line executable bin/free_zipcode_data
  • Support user switches for various options including custom table names
  • Use Kiba for ETL
  • Use in-memory SQLite database to create the tables, then save it as a file on disk
  • Separate concerns for each table and in general

Interested in comments or ideas for improving it.

@midwire midwire requested a review from cmckni3 April 21, 2018 20:04
Copy link
Collaborator

@cmckni3 cmckni3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@midwire midwire merged commit ba54bc6 into develop Apr 23, 2018
@midwire midwire deleted the feature/major_refactor branch April 23, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants