Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timeout from 10 to 30 #84

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Change timeout from 10 to 30 #84

merged 1 commit into from
Jan 18, 2025

Conversation

zvxvx
Copy link
Contributor

@zvxvx zvxvx commented Jan 17, 2025

I had an issue with the script timing out and erroring whenever I tried to set the cron job for the script to run at any other time than every minute.

Changing this from 10 to 30 fixed the problem so custom time set for the cron job works appropriately. I assume this is a self-hosting issue, but I imagine this might be helpful to others self-hosting anyway,

I had an issue with the script timing out whenever I tried to set the cron job for the script to run  at any other time than every minute. Changing this from 10 to 30 fixed the problem.
@saschanaz
Copy link
Contributor

(Also had some timeout issue and had to apply the same modification)

@mietzen mietzen enabled auto-merge January 18, 2025 03:37
@mietzen mietzen disabled auto-merge January 18, 2025 03:39
@mietzen
Copy link
Owner

mietzen commented Jan 18, 2025

I think it's fine to increase the timeout but I don't see that it is related to #76 since we don't get 408 or socket.timeout exceptions.

@mietzen mietzen merged commit 4f4ee89 into mietzen:main Jan 18, 2025
14 checks passed
@zvxvx
Copy link
Contributor Author

zvxvx commented Jan 18, 2025

I think it's fine to increase the timeout but I don't see that it is related to #76 since we don't get 408 or socket.timeout exceptions.

Correct. I deleted my reference earlier, because it wasn't related, but it stuck around anyway.

@shengt25
Copy link

I had an issue with the script timing out and erroring whenever I tried to set the cron job for the script to run at any other time than every minute.

Changing this from 10 to 30 fixed the problem so custom time set for the cron job works appropriately. I assume this is a self-hosting issue, but I imagine this might be helpful to others self-hosting anyway,

I also had the timeout problem on my self-hosting server. For some specific reason it has poor connection quality when dealing with traffic outside the country without a proxy. Almost all updating tasks by cron failed with timeout exception. I tested it usually takes 10-30 seconds for therequest.urlopen in that network environment. (With proxy it only takes around 3 seconds)

Anyway, changing timeout from 10 to 30 provided more tolerance and it works well for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants