implement yarn berry support #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable2fa.getEnable2faArgs is not a function probably from rewriting to esm
can be reproduced by running `np` without an internet connection thereby it thinks that options.availability.isUnknown but the package is not scoped, so it just exits with success (exit code 0)
otherwise it fails with: Response Code: 402 (Payment Required) You must sign up for private packages
tests not yet fixed
This was referenced Nov 8, 2023
# Conflicts: # readme.md
# Conflicts: # readme.md
Co-authored-by: Sindre Sorhus <[email protected]>
|
Hey @mifi do you think we can get this over the finish line, so we can get transloadit/node-sdk#171 over the finish line? It seems awfully close to completion? |
|
Hey, this is actially done upstream. np supports yarn 4. can close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is on top of sindresorhus#721 - don't merge until that is merged
I have tested manually and it works with yarn 4.
TODO tests have not been updated