Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of compiler bugz #1140

Merged
merged 4 commits into from
Mar 2, 2024
Merged

Fix a couple of compiler bugz #1140

merged 4 commits into from
Mar 2, 2024

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Mar 2, 2024

A couple of issues discovered following ssxi errors during incremental compilation:

  • The ssxi declaration for lambdas that had a hand-written inline rule were broken
  • When loading an ssxi, bind a method should be idempotent, ie binding to the same symbol should be allowed.
    As it was it would cause errors during incremental compilation

@vyzo vyzo requested review from fare and a team March 2, 2024 10:41
Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit a75876c
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/65e3027f6f11810008b8b2cd
😎 Deploy Preview https://deploy-preview-1140--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vyzo vyzo mentioned this pull request Mar 2, 2024
4 tasks
Copy link
Collaborator

@fare fare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand much of it, but it doesn't look dangerous, and if it fixes things, then great.

Test case, though?

Copy link
Collaborator

@fare fare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if an issue is created to add a test that indeed breaks at v0.18.1-47-gb409070e

@vyzo
Copy link
Collaborator Author

vyzo commented Mar 2, 2024

Added the general issue in #1142, which is a MUST before we call it production ready.

@fare fare merged commit e993d8f into master Mar 2, 2024
12 checks passed
@fare fare deleted the fix-bugz branch March 2, 2024 15:55
@vyzo
Copy link
Collaborator Author

vyzo commented Mar 2, 2024

Also commented on the issue to remember this particular pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants