-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a couple of compiler bugz #1140
Conversation
this occurs when loading ssxi dependencies
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand much of it, but it doesn't look dangerous, and if it fixes things, then great.
Test case, though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if an issue is created to add a test that indeed breaks at v0.18.1-47-gb409070e
Added the general issue in #1142, which is a MUST before we call it production ready. |
Also commented on the issue to remember this particular pr. |
A couple of issues discovered following ssxi errors during incremental compilation:
As it was it would cause errors during incremental compilation