Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenVPN API Proxy #78

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Add OpenVPN API Proxy #78

merged 4 commits into from
Nov 15, 2021

Conversation

jmontleon
Copy link
Contributor

No description provided.

@jmontleon jmontleon self-assigned this Sep 27, 2021
@jmontleon jmontleon force-pushed the add-vpn-api-access branch 10 times, most recently from 46bf694 to 5faba08 Compare October 1, 2021 16:48
@jmontleon jmontleon marked this pull request as ready for review October 4, 2021 18:03
@jmontleon jmontleon force-pushed the add-vpn-api-access branch 2 times, most recently from 868f3a9 to 0d7bbc5 Compare October 6, 2021 13:56
shawn-hurley
shawn-hurley requested changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good; the only thing that I would like to visit is if we can not rely on minor versions as we are quickly moving to 4.9 and greater, which would cause issues with this logic??

connect/tunnel_api/tunnel_api.go Show resolved Hide resolved
connect/tunnel_api/tunnel_api.go Show resolved Hide resolved
connect/tunnel_api/tunnel_api.go Show resolved Hide resolved
connect/tunnel_api/tunnel_api.go Show resolved Hide resolved
shawn-hurley
shawn-hurley approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sseago sseago merged commit 32ce25d into migtools:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@alaypatel07 alaypatel07 Awaiting requested review from alaypatel07

@pranavgaikwad pranavgaikwad Awaiting requested review from pranavgaikwad

Assignees

@jmontleon jmontleon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmontleon @shawn-hurley @alaypatel07 @sseago