Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove LabelCustomColor (moving it to tackle2-ui) #141

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Oct 4, 2023

@migtools-preview-bot
Copy link

🚀 Deployed Storybook Preview: http://migtools-lib-ui-pr-141-preview.surge.sh

mturley added a commit to konveyor/tackle2-ui that referenced this pull request Oct 4, 2023
…dating it for PF5 (#1431)

Moves the `LabelCustomColor` component into this repo from
https://github.com/migtools/lib-ui and updates the CSS variable names it
uses to include the `pf-v5-c-*` version prefix that is new in PF5. This
fixes the tags in the app inventory page losing their colors in the PF5
upgrade.

See migtools/lib-ui#141 for the corresponding
removal from lib-ui.

Before:
![Screenshot 2023-10-04 at 2 47 07
PM](https://github.com/konveyor/tackle2-ui/assets/811963/a63b42bc-6101-4d9e-99cf-77e010ff01b4)

After:
![Screenshot 2023-10-04 at 2 46 46
PM](https://github.com/konveyor/tackle2-ui/assets/811963/c851fb1b-1ba5-4a62-9090-9521c4316cad)

Signed-off-by: Mike Turley <[email protected]>
@mturley mturley merged commit 0cb74ce into migtools:main Oct 5, 2023
4 checks passed
@mturley mturley deleted the remove-label-custom-color branch October 5, 2023 00:31
@migtools-release-bot
Copy link
Collaborator

🎉 This PR is included in version 10.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants