fix: Enable more linters #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusoliveira43
commented
Mar 5, 2024
mateusoliveira43
commented
Mar 5, 2024
| allow-parallel-runners: true | ||
| skip-dirs: |
There was a problem hiding this comment.
will remove these skips prior to merge
There was a problem hiding this comment.
will let this one for another PR
we are not using e2e yet
|
@mpryc can you check the current errors and see with you agree on us fixing all of them, or if there are some that we should skip? |
mateusoliveira43
commented
Mar 5, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
Signed-off-by: Mateus Oliveira <[email protected]>
mateusoliveira43
force-pushed
the
fix/more-linters
branch
from
d8e62c1
to
73cdaf4
Compare
Signed-off-by: Mateus Oliveira <[email protected]>
Signed-off-by: Mateus Oliveira <[email protected]>
kaovilai
reviewed
Mar 7, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
mateusoliveira43
commented
Mar 7, 2024
There was a problem hiding this comment.
here we could separate in more files, but did not focused on this in this PR
|
/lgtm tested |
Signed-off-by: Mateus Oliveira <[email protected]>
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable more strict checks with Go linters using golangci-lint.