fix: Enforce NonAdminBackup spec field values #110
+613
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mateusoliveira43
commented
Nov 8, 2024
mateusoliveira43
commented
Nov 8, 2024
go.mod
Outdated
| sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect | ||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect | ||
| sigs.k8s.io/yaml v1.4.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/vmware-tanzu/velero => github.com/openshift/velero v0.10.2-0.20240919150610-92244630d90b | ||
|
|
||
| replace github.com/openshift/oadp-operator => github.com/mateusoliveira43/oadp-operator v0.0.0-20241108184219-7913bfce1719 |
There was a problem hiding this comment.
TODO remove this prior to merge
mateusoliveira43
force-pushed
the
fix/enforce-backup-spec-field-values
branch
from
187da0e
to
dba046c
Compare
shubham-pampattiwar
requested changes
Nov 12, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
mateusoliveira43
force-pushed
the
fix/enforce-backup-spec-field-values
branch
from
c4c3074
to
306351b
Compare
| setupLog.Error(err, "unable to create Kubernetes client") | ||
| os.Exit(1) | ||
| } | ||
| // TODO we could pass DPA name as env var and do a get call directly. Better? |
| name: "IncludedNamespaces", | ||
| }, | ||
| { | ||
| // should not be enforced? |
run make manifests Signed-off-by: Mateus Oliveira <[email protected]>
|
/hold Blocked by openshift/oadp-operator#1584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes were made
Resolves #33
Related to: #37
Blocked by: openshift/oadp-operator#1584
This PR adds fetching of OADP's DPA during NAC set up, adding DPA
spec.nonAdmin.enforceBackupSpectoNonAdminBackupReconcilerand adds validation for NonAdminBackup spec respecting enforcement.How to test the changes made
Read design.
Follow install-from-source testing documentation, pointing this branch and my OADP fork branch
fix/enforce-non-admin-bckup-spec-field-values