Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting NaBSL prefix #172

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shubham-pampattiwar
Copy link
Member

Why the changes were made

Fixes #144

How to test the changes made

  • Try creating a NaBSL object by setting a prefix
  • Try creating a NaBSL object without setting a prefix
  • Run unit tests (make simuation-test)

@openshift-ci openshift-ci bot requested review from kaovilai and mrnold February 6, 2025 18:54
@openshift-ci openshift-ci bot added the approved label Feb 6, 2025
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a uniqueness expected here of the prefix? Is it on the user?

@mateusoliveira43
Copy link
Contributor

@tiger yes, but not on user side, on our side, to avoid synchronizing wrong backups

Copy link
Contributor

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not able to test because of the problem I am having, info in slack

but tested adding a prefix with / and works for IBM COS

Copy link

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mateusoliveira43,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NaBSL prefix needs to be unique
3 participants