Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpointer BackupSpec and BackupStatus from NAB type #81

Closed
wants to merge 4 commits into from

Conversation

kaovilai
Copy link
Member

  • Make nab.veleroBackupStatus not a pointer
  • make nab.BackupSpec not a pointer
  • Getters/Validators should not pass by pointer

Why the changes were made

How to test the changes made

Copy link

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai
Copy link
Member Author

nvm nab probably has so many nested fields.. it merits pointer :)

@kaovilai kaovilai closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant