-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change project domain #96
fix: Change project domain #96
Conversation
Skipping CI for Draft Pull Request. |
domain-change.diff
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove prior to merge, just to show the diff file used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still in the latest force push, need to remove that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this PR and also create a corresponding OADP operator PR simultaneously.
Why are we moving the group out of nac to just oadp? |
@shawn-hurley , @mpryc first implementations with webhook in OADP side suggested would be easier if NAC objects have same group as OADP objects @shubham-pampattiwar waiting to see if we will need this for that implementation. If not, I will close this one without merging |
yeah we need this. Basically:
|
5cb5c81
to
2cb7348
Compare
Signed-off-by: Mateus Oliveira <[email protected]>
change domain in docs Signed-off-by: Mateus Oliveira <[email protected]>
doc change Signed-off-by: Mateus Oliveira <[email protected]>
2cb7348
to
e414e2f
Compare
remove diff Signed-off-by: Mateus Oliveira <[email protected]>
/hold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43, mpryc, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retry oadp-compatibility-check |
/unhold |
Why the changes were made
Change project domain for easier webhook integration with OADP.
Change were made following kubebuilder upgrade documentation.
Blocked by openshift/oadp-operator#1589
How to test the changes made
Check all places where changed (
grep -Inr "nac.oadp.openshift.io" .
)Run the project following development documentation and check if nothing broke with the changes.