Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix backLen comparison in MFRC522Extended.cpp #631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

supcik
Copy link

@supcik supcik commented Jun 3, 2024

The comparison of backLen in MFRC522Extended.cpp was incorrect. When compiled in ESP/IDF, the compiler gave the error : "ordered comparison of pointer with integer zero"

Q A
Bug fix? yes
New feature? no
Doc update? no
BC breaks? no
Deprecations? no
Fixed tickets none

The comparison of backLen in MFRC522Extended.cpp was incorrect. When compiled in ESP IDF, the compiler gave the error : "ordered comparison of pointer with integer zero"
@Jan21021
Copy link

Jan21021 commented Jun 9, 2024

i just tested this fix with a esp32 nodemcu. it works: cardreader is functional.

@Jeff86
Copy link

Jeff86 commented Jun 17, 2024

Better use nullptr instead of NULL. I had this issue and fixed it with if (backData && (backLen != nullptr))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants