Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed Ehancement: Replace PIL with OpenCV #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ss32
Copy link

@ss32 ss32 commented Sep 18, 2021

  • Removes dependency on PIL in favor of OpenCV
  • No longer writes temporary frames to file
  • Generates video on the fly

This significantly speeds up the video generation process.

  * Removes dependency on PIL in favor of OpenCV
  * No longer writes temporary frames to file
  * Generates video on the fly
@oleczek
Copy link

oleczek commented Sep 28, 2021

@ss32 Do you think it would be possible to run it entirely on the fly - I mean live? E.g. stream the music, or get it from the microphone / aux?

@fractaldna22
Copy link

if it doesnt write frames to file this means that if you make an entire video and an error doesnt come up till the very end i.e. "folder doesnt exist" or "no such module as google.colab.files", ALL your work will get deleted forever and there will be no way to recover it. this happened so many times on the old Deep music visualizer and its outrageous and unacceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants