forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FTR] fix flaky:
cmn/mgmt/data_views/_edit_field.ts
(elastic#194738)
## Summary What I tried before pushing 1. Better specificity - Couldn't get it just right (due to the dom structure) 1. Changing dom structure - Couldn't do that how I would like, due to the structure of `.tsx` file So, I went with adding a service method that simply filters down by two table dropdowns, instead of one. _Sadly I spend most of my time with the specificity (different css combinators), so lesson learned there_. Also, cleaned up the test code to simply call the service method and nothing more. ### Note ~~Will probably drop the other added service method (`openEditFlyoutByRowNumber`)~~ ✅ Resolves: elastic#194662
- Loading branch information
1 parent
d22b830
commit 620b8bf
Showing
2 changed files
with
21 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters