Skip to content

Commit

Permalink
[Search/Connector] Make minute-level scheduling default option in Con…
Browse files Browse the repository at this point in the history
…nectorCronEditor (elastic#189250)

## Summary

Enable minute level scheduling in UI for all connector sync jobs. This
fixes the bug with minute level scheduling not present for incremental
sync jobs.

It seems that during [this
migration](elastic@bb5ca2e#diff-328630e75e33bdb823bad243330681942ab5a391c5b83cad7f3186c4ca651e9dL219)
the minute level scheduling for incremental syncs was lost somehow.

As of now the `ConnectorCronEditor` is only used for connector sync
jobs, all connector sync jobs support minute-level scheduling so I
deleted the `MINUTE` from default `frequencyBlockList` in the component.

<img width="680" alt="Screenshot 2024-07-26 at 10 32 16"
src="https://github.com/user-attachments/assets/7070227e-b332-4217-beea-a169c8b3d4fc">
  • Loading branch information
jedrazb authored Jul 26, 2024
1 parent 6ddffb5 commit 754de3b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ interface ConnectorCronEditorProps {
export const ConnectorCronEditor: React.FC<ConnectorCronEditorProps> = ({
dataTelemetryIdPrefix,
disabled = false,
frequencyBlockList = ['MINUTE'],
frequencyBlockList = [],
hasSyncTypeChanges,
onReset,
onSave,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,6 @@ export const ConnectorContentScheduling: React.FC<ConnectorContentSchedulingProp
hasSyncTypeChanges={hasSyncTypeChanges}
setHasSyncTypeChanges={setHasSyncTypeChanges}
disabled={isGated}
frequencyBlockList={
type === SyncJobType.ACCESS_CONTROL || type === SyncJobType.FULL ? [] : undefined
}
scheduling={scheduling[type]}
onReset={() => {
setScheduling({
Expand Down

0 comments on commit 754de3b

Please sign in to comment.