forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fleet] Remove duplicative retries from client-side requests to APIs …
…that depend on EPR (elastic#190722) ## Summary Relates to elastic#136617 For APIs that depend on Fleet connecting to Elastic Package Registry, Fleet already retries the connections to EPR on the server side. This results in a situation where, when EPR is unreachable, the requests is retried several times on the server side, and then the request is retried again on the client-side by react-query. This results in very long running API requests. Since the server-side retries generally cover any kind of flakiness here, disabling the retry logic on the front-end seems sensible. ~I've also reduced the number of retries on the server side from 5 to 3 to help fail faster here.~ I walked back the retry change after some test failures, and I don't think it makes a big enough impact to justify changing. ## To test Set `xpack.fleet.registryUrl: 127.0.0.1:8080` with nothing running ## Before The requests spin for a very long time. https://github.com/user-attachments/assets/e4fd77ee-b36c-4965-9f71-e5b3e195f75e ## After The requests stop spinning after a few seconds as the retries won't loop. https://github.com/user-attachments/assets/82adc595-1bc4-4269-8501-2eb83525ad15 cc @shahzad31
- Loading branch information
Showing
3 changed files
with
47 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters