Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Start running typeguard #2163

Merged
merged 12 commits into from
Feb 26, 2024
Merged

Release: Start running typeguard #2163

merged 12 commits into from
Feb 26, 2024

Conversation

mikedh
Copy link
Owner

@mikedh mikedh commented Feb 26, 2024

  • release Fix typing for lights in Scene.__init__ #2162
    • to catch similar wrong type hint bugs, the docker tests run with typeguard. Initially this is only on a subset of modules and tests.
    • Getting the whole codebase to pass with typeguard is a big project but would be nice.
  • disallows implicit string concatenation in most cases with the rule suggested in [Feature request]: support flake8-no-implicit-concat (NIC) astral-sh/ruff#8549
  • deprecates trimesh.resources.get in favor of typed functions i.e. trimesh.resources.get_json
  • remove the deprecated trimesh.interfaces.scad as now we use manifold3d directly for boolean operations. OpenSCAD also uses manifold as a back end so it doesn't make sense to maintain this indirect interface.

@mikedh mikedh merged commit 3966450 into main Feb 26, 2024
9 checks passed
@mikedh mikedh deleted the feat/typeguard branch February 26, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants