Release: Use Debian Docker Base Image #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to use the first-party
debianbase images with python fromaptand a uservenv, instead of using thepython:3.12-slim-bookwormDebian base images. This shouldn't make any difference to users of the upstream Docker images unless you were relying on copying/home/user/.localwhich would now be/home/user/venvpythondocker images are from the Docker organization not the Python Software Foundation so the builds are of comparable levels of "official."trimeshtest suite in Docker appeared to take 11m 41s onpython:3.12-slim-bookwormvs 9m 24s ondebian:trixie-slim(this PR), a roughly 20% improvement which is in-line with the synthetic benchmark.